Remove return types from getUser as they were not correct.#156
Merged
ottokruse merged 18 commits intoaws-samples:mainfrom Mar 27, 2024
fahadsadiq:main
Merged
Remove return types from getUser as they were not correct.#156ottokruse merged 18 commits intoaws-samples:mainfrom fahadsadiq:main
ottokruse merged 18 commits intoaws-samples:mainfrom
fahadsadiq:main
Conversation
Added access token param for stepUpAuthenticationWithSmsOtp
Contributor
|
Hey mate can we instead of removing it just change the type to what it needs to be? Should be easy, can almost copy it verbatim from the docs |
Contributor
Author
|
Done |
Contributor
|
Lat req, can you tweak it to this, otherwise TS might do funny and understand the lists to be fixed size: interface GetUserResponse {
MFAOptions: {
AttributeName: string;
DeliveryMedium: string;
}[];
PreferredMfaSetting: string;
UserAttributes: {
Name: string;
Value: string;
}[];
UserMFASettingList: string[];
Username: string;
}THANKS |
Contributor
Author
|
Updated. |
Contributor
|
Hey mate you added the type to the wrong function, to Nearly weekend my friend :) |
Long week. :)
Contributor
Author
|
Fixed the issue. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Another oversight from my side. Apologies. I have tested this end to end and it works fine.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.