Skip to content

Remove return types from getUser as they were not correct.#156

Merged
ottokruse merged 18 commits intoaws-samples:mainfrom
fahadsadiq:main
Mar 27, 2024
Merged

Remove return types from getUser as they were not correct.#156
ottokruse merged 18 commits intoaws-samples:mainfrom
fahadsadiq:main

Conversation

@fahadsadiq
Copy link
Contributor

Issue #, if available:

Another oversight from my side. Apologies. I have tested this end to end and it works fine.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ottokruse
Copy link
Contributor

Hey mate can we instead of removing it just change the type to what it needs to be? Should be easy, can almost copy it verbatim from the docs

@fahadsadiq
Copy link
Contributor Author

Done

@ottokruse
Copy link
Contributor

Lat req, can you tweak it to this, otherwise TS might do funny and understand the lists to be fixed size:

interface GetUserResponse {
  MFAOptions: {
      AttributeName: string;
      DeliveryMedium: string;
    }[];
  PreferredMfaSetting: string;
  UserAttributes:  {
      Name: string;
      Value: string;
    }[];
  UserMFASettingList: string[];
  Username: string;
}

THANKS

@fahadsadiq
Copy link
Contributor Author

Updated.

@ottokruse
Copy link
Contributor

Hey mate you added the type to the wrong function, to revokeToken instead of getUser.

Nearly weekend my friend :)

@fahadsadiq
Copy link
Contributor Author

Fixed the issue.

Copy link
Contributor

@ottokruse ottokruse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks again

@ottokruse ottokruse merged commit 7e1017b into aws-samples:main Mar 27, 2024
@ottokruse
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants