Refactor dependencies: remove peer deps and upgrade react-native-passkey#180
Merged
EricBorland merged 3 commits intoaws-samples:mainfrom Jun 25, 2024
Merged
Conversation
EricBorland
approved these changes
Jun 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #167
Description of changes: All peer dependencies have been removed from
package.json, except foresbuild. Even though technically less "correct" this does make it a lot quicker, and more importantly, less painful to install this library. Previously, installing it often required using the--forceflag, because we had a peer dependency toreact-native-passkeywhich (via React Native) required React 18.2 while users may have already been on React 18.3.Installation will be quicker because e.g. if you're in a React project and you install this library, you won't unnecessarily also get AWS CDK installed (and in an AWS CDK project, you won't unnecessarily get React installed).
Yes, us mixing CDK and front-end code in one NPM module has its upside (just 1 module on NPM) but certainly also its downsides.
Anyway, while at it I also upgraded our code to work with the latest and greatest
react-native-passkey(and marked that version in the README) and updated all other dependencies.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.