Skip to content

Adding changes to deploy frontend on Windows and Mac#186

Merged
ottokruse merged 3 commits intoaws-samples:mainfrom
dcorralf:deploy-frontend
Aug 20, 2024
Merged

Adding changes to deploy frontend on Windows and Mac#186
ottokruse merged 3 commits intoaws-samples:mainfrom
dcorralf:deploy-frontend

Conversation

@ghost
Copy link

@ghost ghost commented Aug 18, 2024

Issue #, if available:

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Adding some changes to script "deploy-spa.cjs" and "package.json" files to deply the frontend on Windows and Mac.

@ottokruse
Copy link
Contributor

Hey mate looks good but please run prettier :)

npx prettier -w .

@ghost
Copy link
Author

ghost commented Aug 19, 2024

Hi Otto, I've executed prettier and I have pushed the new code, also I 've changed the script name in deploy-spa.cjs file. Let me know any further problem please.

@ottokruse
Copy link
Contributor

Hey mate pettier is still complaining.

Can you double check?

npx prettier -c .

@ghost
Copy link
Author

ghost commented Aug 19, 2024

Hi Otto, sorry, my bad, I'm not familiar with prettier and I've executed in a wrong way. Now I think it's all ok !

@ottokruse ottokruse merged commit db36d3e into aws-samples:main Aug 20, 2024
@ottokruse
Copy link
Contributor

Thanks mate!

@ghost
Copy link
Author

ghost commented Aug 20, 2024

It's a pleasure! Whatever it takes!

@ghost ghost deleted the deploy-frontend branch August 20, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants