feat: improve error reporting for invalid magic links#210
Merged
ottokruse merged 1 commit intoaws-samples:mainfrom Nov 11, 2024
Merged
Conversation
aashir-motorway
force-pushed
the
improve-invalid-magic-link-error-reporting
branch
from
a164c2e to
49ad1d1
Compare
TKostrzewskiMotorway
approved these changes
Nov 7, 2024
aashir-motorway
force-pushed
the
improve-invalid-magic-link-error-reporting
branch
from
6b85b03 to
cb9a979
Compare
feat: improve error reporting for invalid magic links feat: improve error reporting for invalid magic links fix: unkown template literal error fix: unkown template literal error
aashir-motorway
force-pushed
the
improve-invalid-magic-link-error-reporting
branch
from
cb9a979 to
91fc996
Compare
ottokruse
approved these changes
Nov 11, 2024
Contributor
|
Thank you! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR enhances error visibility for invalid magic link handling in the UI. Currently, an invalid magic link would throw a generic error message
Ignoring invalid fragment identifier, which provided minimal context and made debugging challenging.It took us sometime to identify the issue and this PR introduces more descriptive error handling to help quickly understand the root cause with invalid magic links.
Results: