Skip to content
This repository was archived by the owner on Aug 1, 2024. It is now read-only.

Implement build, synth, and test checks in CI #259

Closed
1 of 2 tasks
ryparker opened this issue Aug 5, 2021 · 1 comment · Fixed by #264, #265, #266, #268 or #269
Closed
1 of 2 tasks

Implement build, synth, and test checks in CI #259

ryparker opened this issue Aug 5, 2021 · 1 comment · Fixed by #264, #265, #266, #268 or #269
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@ryparker
Copy link
Contributor

ryparker commented Aug 5, 2021 •
edited
Loading

🚀 Feature Request

General Information

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

Description

We should make sure PRs are checked for

  • site builds successfully
  • sample code cdk synth's successfully
  • sample code tests pass

Proposed Solution

Implement GitHub workflows for all 3 checks to be ran on every PR.
@ryparker ryparker added needs-triage This issue or PR still needs to be triaged. feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 5, 2021
@ryparker ryparker changed the title Implement build and test checks in CI Implement build, synth, and test checks in CI Aug 5, 2021
This was referenced Aug 6, 2021
Closed
Merged
This was referenced Aug 13, 2021
Merged
Merged
Closed
Merged
Merged
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
1 participant
@ryparker