fix(csharp): fixed sample code and created CI job to validate #268
Conversation
|
"### Pull Request Checklist * [ ] Testing - Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change) * [ ] Title and Description - Change type: title prefixed with fix, feat and module name in parens, which will appear in changelog - Title: use lower-case and doesn't end with a period - Breaking?: last paragraph: 'BREAKING CHANGE: <describe what changed + link for details>' - Issues: Indicate issues fixed via: 'Fixes #xxx' or 'Closes #xxx'" |
workshop/content/40-dotnet/70-advanced-topics/100-pipelines/3000-new-pipeline.md
Outdated
Show resolved
Hide resolved
…ewer at version [0.1.*,3)
|
|
||
| <PackageReference Include="Amazon.Jsii.Analyzers" Version="*" PrivateAssets="all" /> |
There was a problem hiding this comment.
No longer necessary. Removed
|
|
||
| <PackageReference Include="Eladb.DynamoTableViewer" Version="3.0.6" /> | ||
| <PackageReference Include="Eladb.DynamoTableViewer" Version="[0.1.*,3)" /> |
There was a problem hiding this comment.
This version specification was required in order for Eladb.DynamoTableViewer to share compatible peer dependencies with the latest CDK packages.
|
|
||
| <PackageReference Include="Eladb.DynamoTableViewer" Version="3.1.2" /> | ||
|
|
||
| <PackageReference Include="Amazon.Jsii.Analyzers" Version="*" PrivateAssets="all" /> |
There was a problem hiding this comment.
same changes as main-workshop
| "npm install -g aws-cdk", | ||
| "sudo apt-get install -y dotnet-sdk-3.1" | ||
| }, | ||
| BuildCommands = new [] { "dotnet build" } // Language-specific build cmd |
There was a problem hiding this comment.
Deprecated API params
| @@ -62,7 +62,7 @@ namespace CdkWorkshop | |||
|
|
|||
| ## Now we can access the table from our stack | |||
|
|
|||
| Go back to `CdkWorkshop.cs` and assign the `Table` property of the table viewer: | |||
There was a problem hiding this comment.
CdkWorkshop is a directory not a file. This seems to be talking about src/CdkWorkshop/CdkWorkshopStack.cs
Summary
This PR implements CI workflows that verify changes do not break builds.
cdk synthFixes #259, #175, #152
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.