chore: update samples without JS SDK from node 16 to 20 #2292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since there are too many to check manually, I randomly looked at some patterns and confirmed that no AWS SDK is used. Can you verify this is true for all the updated patterns? |
Yes. I've verified that the Lambdas in this PR does not use JS SDK. |
trivikr
force-pushed
the
lambda-runtime-node20
branch
from
007a805 to
994a21c
Compare
|
@cornelcroi Any update on this PR? |
trivikr
force-pushed
the
lambda-runtime-node20
branch
from
994a21c to
4ca0554
Compare
|
@cornelcroi Any other updates needed to get this PR reviewed? |
cornelcroi
approved these changes
Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Refs: #2290
Description of changes:
Updates samples which does not use AWS SDK for JavaScript from node 16 to 20.
The samples which use AWS SDK for JavaScript will need migration to JS SDK v3, and were done in #2293
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.