Skip to content

Add basic CI #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 5, 2021
Merged

Add basic CI #3

merged 4 commits into from
Oct 5, 2021

Conversation

brainstorm
Copy link
Contributor

Description of changes: Add continuous integration via GHA to catch issues like #2 early.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@brainstorm
Copy link
Contributor Author

brainstorm commented Oct 1, 2021

@nmoutschen I guess you noticed already, but I'll be explicit: I'd suggest not merging this until issue #2 is fixed, because it also fails the same way on CI anyway, see: https://github.com/brainstorm/serverless-rust-demo/runs/3762807603#step:9:91

@nmoutschen
Copy link
Contributor

I've added gcc-aarch64-linux-gnu, which fixes the CI.

For issues in #2 and more, I need to continue experimenting on setting up and/or using the right toolchain for cross--compilation.

@nmoutschen nmoutschen merged commit 4b477c2 into aws-samples:main Oct 5, 2021
@bnusunny
Copy link
Contributor

bnusunny commented Oct 6, 2021

For musl builds, check out https://musl.cc/. Works pretty well.

@brainstorm
Copy link
Contributor Author

For musl builds, check out https://musl.cc/. Works pretty well.

Check awslabs/aws-lambda-rust-runtime#306... MUSL introduces unnecessary static bloat when provided.al2 already supports native GLIBC binaries, plus you can relatively easily change the allocator to optimize performance further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants