Skip to content

Add toggle to run test without downloading embedded resources #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ErikBooijFR
Copy link

Currently, by default all tests ran will download all resources embedded in the page. For most cases this is probably a sensible default. However in our case (and this probably isn't really an edge case either) we're serving HTML from our own servers, and serving assets from a CDN.

We want to be able to load test our own service, without accessing the CDN, because:

  • It's more representative of the metric we're actually interested in (our servers' performance, not the end-users' total load time).
  • We avoid getting rate limited by the CDN, skewing our results.

Description of changes:
This change proposes adding a checkbox labeled "Retrieve embedded resources" under the "Endpoint" field in the "Simple" test type. By default it's checked, so if a user doesn't touch it, the behaviour doesn't change from the current state.

Screenshot 2025-06-27 at 13 59 29

The value of the checkbox is passed to the retrieve-resources property in the generated test definition. See https://gettaurus.org/docs/JMeter/#Global-Settings.

I have not added the checkbox to the form for creating a test from a JMeter test definition file, since it's impossible to tell what's in there and if/how the flag would affect it.

Checklist

  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant