Add toggle to run test without downloading embedded resources #239
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, by default all tests ran will download all resources embedded in the page. For most cases this is probably a sensible default. However in our case (and this probably isn't really an edge case either) we're serving HTML from our own servers, and serving assets from a CDN.
We want to be able to load test our own service, without accessing the CDN, because:
Description of changes:
This change proposes adding a checkbox labeled "Retrieve embedded resources" under the "Endpoint" field in the "Simple" test type. By default it's checked, so if a user doesn't touch it, the behaviour doesn't change from the current state.
The value of the checkbox is passed to the
retrieve-resources
property in the generated test definition. See https://gettaurus.org/docs/JMeter/#Global-Settings.I have not added the checkbox to the form for creating a test from a JMeter test definition file, since it's impossible to tell what's in there and if/how the flag would affect it.
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.