Skip to content

Conversation

@danehlim
Copy link
Contributor

@danehlim danehlim commented Oct 26, 2023

Summary

Update ECS model defined in ecs-agent/api/ecs/model/ with missing fields and consume the aforementioned ECS model.

The missing fields that were added can be seen in the diff introduced by this pull request to the ecs-agent/api/ecs/model/api/api-2.json file. For reference, those fields were introduced in the following previous pull requests:

Implementation details

  1. Update ECS model defined in ecs-agent/api/ecs/model/ with missing fields
    • Add missing fields to ecs-agent/api/ecs/model/api/api-2.json file
    • Run make gogenerate to re-generate the .go files in ecs-agent/api/ecs/model/ecs/
  2. Consume the ECS model files defined in ecs-agent/api/ecs/model/ecs/
    • Replace imports of github.com/aws/amazon-ecs-agent/ecs-agent/ecs_client/model/ecs with github.com/aws/amazon-ecs-agent/ecs-agent/api/ecs/model/ecs
    • Remove ecs-agent/ecs_client directory and all files contained within that directory as it is no longer used

Testing

Unit, integration, and functional tests.

New tests cover the changes: no

Description for the changelog

Update ecs-agent/ ECS model with missing fields + consume the same

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@danehlim danehlim force-pushed the consume-new-ecs-model branch from 695eb47 to a31c7ad Compare October 26, 2023 22:51
@danehlim danehlim marked this pull request as ready for review October 26, 2023 23:17
@danehlim danehlim requested a review from a team as a code owner October 26, 2023 23:17
@danehlim danehlim merged commit 13c1643 into aws:dev Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants