Skip to content

Conversation

@mye956
Copy link
Contributor

@mye956 mye956 commented Apr 10, 2025

Summary

This PR will clean up the short term solution of the and added one more region where we could be hitting issues with resolving the endpoints through docker. Long term solution is to not do this/remove this short term workaround altogether.

Related PR: #4143

Implementation details

  • Added us-isob-west-1 to the list of regions to do the short term solution to resolve the correct endpoint for Cloudwatch
  • Tidy up the code a bit by using a "set" to store all of the regions where we need to use this short term solution

Testing

Added new unit test case

New tests cover the changes: yes

Description for the changelog

Enhancement - Modify CW endpoint short term solution to include more regions

Additional Information

Does this PR include breaking model changes? If so, Have you added transformation functions?

Does this PR include the addition of new environment variables in the README?

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mye956 mye956 requested a review from a team as a code owner April 10, 2025 21:10
@mye956 mye956 changed the title [WIP] Modify CW endpoint short term solution to include more regions Modify CW endpoint short term solution to include more regions Apr 10, 2025
@mye956 mye956 enabled auto-merge (rebase) April 10, 2025 23:15
@mye956 mye956 force-pushed the modify-cw-endpoint-regions branch from 61680e7 to 87c95e1 Compare April 14, 2025 15:56
@mye956 mye956 merged commit 2035cee into aws:dev Apr 14, 2025
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants