Skip to content

Conversation

@Yiyuanzzz
Copy link
Contributor

Summary

Migrate FSX to aws-sdk-go-v2

Implementation details

  • Updated the FSxClient interface to use the new method signature with context.Context and variadic options for fsx.DescribeFileSystems
  • Migrate from session.Session to aws.Config per the docs.
  • Updated test assertions to align with the new SDK v2 types ([]types.FileSystem instead of []*fsx.FileSystem).
  • Replacement of aws.StringValue() to aws.ToString()

Testing

New tests cover the changes: no

Description for the changelog

Enhancement: Migrate FSX to aws-sdk-go-v2

Additional Information

Does this PR include breaking model changes? If so, Have you added transformation functions?

Does this PR include the addition of new environment variables in the README?

Licensing

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Yiyuanzzz Yiyuanzzz requested a review from a team as a code owner May 5, 2025 23:06
@Yiyuanzzz Yiyuanzzz enabled auto-merge (squash) May 5, 2025 23:35
ShelbyZ
ShelbyZ previously approved these changes May 6, 2025
mye956
mye956 previously approved these changes May 6, 2025
@Yiyuanzzz Yiyuanzzz dismissed stale reviews from mye956 and ShelbyZ via 39d96aa May 6, 2025 17:12
@Yiyuanzzz Yiyuanzzz merged commit dabc544 into dev May 6, 2025
45 checks passed
timj-hh pushed a commit to timj-hh/amazon-ecs-agent that referenced this pull request Jul 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants