ECS Client dual stack endpoint usage #4652
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheanLim
approved these changes
May 27, 2025
prateekchaudhry
approved these changes
May 27, 2025
xxx0624
pushed a commit
to xxx0624/amazon-ecs-agent
that referenced
this pull request
May 28, 2025
timj-hh
pushed a commit
to timj-hh/amazon-ecs-agent
that referenced
this pull request
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes Agent initialize ECS Client with
WithDualStackEnabledoption. DualStack usage is enabled on IPv6-only instances and disabled on non-IPv6-only instances.Testing
I made a code change to temporarily enable AWS SDK logging. Then I observed
docker logsof the agent container.On an IPv6-only instance, the following line was part of SDK logging, verifying that dual-stack ECS endpoint was used.
On a non-IPv6-only instance, the following line was part of SDK logging, verifying that legacy ECS endpoint was used.
New tests cover the changes: no
Description for the changelog
Enhancement: Use dual-stack ECS endpoints if instance is IPv6-only.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions?
No
Does this PR include the addition of new environment variables in the README?
No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.