Move duplicate awsrulesfn package to the ecs-agent module #4661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prateekchaudhry
approved these changes
May 28, 2025
ShelbyZ
approved these changes
May 28, 2025
timj-hh
pushed a commit
to timj-hh/amazon-ecs-agent
that referenced
this pull request
Jul 19, 2025
* remove duplicate awsrulesfn to ecs-agent * go mod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, both the agent and ecs-init modules have an awsrulesfn package. This PR moves the duplicate awsrulesfn package to the ecs-agent module, as ecs-init now also depends on the ecs-agent module..
Testing
New tests cover the changes: N/A
Description for the changelog
enhencement: Move duplicate awsrulesfn package to the ecs-agent module
Additional Information
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.