bugfix: Fix "default" ecs cluster auto-create logic #4689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes agent's ClusterNotFound error handling, which is returned as a ClientException in the case that the agent calls RCI and the cluster does not exist.
Testing
A new unit test file was added for testing the entire errors package, including this function.
Manual test was run to confirm that an account/region with no default cluster now has one auto-created and agent is able to register with the default cluster:
New tests cover the changes: yes
Description for the changelog
bugfix: Fix "default" ecs cluster auto-create logic
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.