Service Connect stats bugfix #4796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShelbyZ
approved these changes
Oct 9, 2025
mye956
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with Service Connect stats.
The ECS agent collects Service Connect (SC) stats from the SC relay daemon container. Currently, the ECS agent stops collecting stats as soon as one container of an ECS task stops. This becomes an issue when the ECS task has a non-essential container - SC stats stop being reported to ECS control-plane, even though other essential containers are running.
Implementation details
Updated the ECS agent stats cleanup logic - only stop collecting SC stats when all containers of the ECS task stop.
Testing
New tests cover the changes: Yes, added a new unit test, and also tested this end-to-end with the help of ECS networking team.
Description for the changelog
Bugfix: Stop collecting Service Connect stats only when there are zero running containers in the task.
Additional Information
Does this PR include breaking model changes? If so, Have you added transformation functions? No
Does this PR include the addition of new environment variables in the README? No
Licensing
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.