Skip to content

chore: fix some issues with release#156

Merged
kessplas merged 1 commit intomainfrom
release-improvement
Apr 7, 2023
Merged

chore: fix some issues with release#156
kessplas merged 1 commit intomainfrom
release-improvement

Conversation

@kessplas
Copy link
Contributor

@kessplas kessplas commented Apr 6, 2023

Issue #, if available:

Description of changes:

  • Adds a missing SecretsManager permission to CloudFormation (which was manually added during the 3.0.0 release)
  • Removes an extraneous :jar from the look_4_artifact.sh script. From the build output, this was running:
[INFO] Resolving software.amazon.encryption.s3:amazon-s3-encryption-client-java:jar:jar with transitive dependencies
4289

Removing the extra :jar succeeds in resolution.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.

@kessplas kessplas marked this pull request as ready for review April 6, 2023 21:59
@kessplas kessplas requested a review from a team as a code owner April 6, 2023 21:59
texastony
texastony reviewed Apr 7, 2023
View reviewed changes
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking question

@kessplas kessplas merged commit c6b4e64 into main Apr 7, 2023
@kessplas kessplas deleted the release-improvement branch April 7, 2023 21:02
aws-crypto-tools-ci-bot pushed a commit that referenced this pull request Jun 1, 2023
@semantic-release-bot
Amazon S3 Encryption Client 3.0.1 Release -- $(date +%Y-%m-%d)
74ed21d 
### [3.0.1](v3.0.0...v3.0.1) (2023-06-01)

### Maintenance

* add metadata downgrade tests([#55](#55)) ([0fed900](0fed900))
* fix some issues with release ([#156](#156)) ([c6b4e64](c6b4e64))

### Fixes

* null check for InputStream in ApiNameVersion ([#161](#161)) ([c23aeb2](c23aeb2))
* unwrap CompletionException in default client, rethrow as S3Encry… ([#162](#162)) ([1a00d3e](1a00d3e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@texastony texastony texastony approved these changes

@josecorella josecorella Awaiting requested review from josecorella

@lucasmcdonald3 lucasmcdonald3 Awaiting requested review from lucasmcdonald3

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kessplas @texastony