Conversation
…n BoundedStreamBufferer
kessplas
changed the title
josecorella
pushed a commit
that referenced
this pull request
Jun 18, 2024
## [3.1.3](v3.1.2...v3.1.3) (2024-06-18) ### Fixes * Ranged gets with RSA keys ([#288](#288)) ([5d7fc31](5d7fc31)) * set bufferSize to 1 when bufferSize is less than or equal to 0 in BoundedStreamBufferer ([#283](#283)) ([adb6d3b](adb6d3b)) ### Maintenance * add support policy ([#236](#236)) ([264168d](264168d))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
No issue, but see https://github.com/aws/amazon-s3-encryption-client-java/actions/runs/9288503510/job/25560124190 for failed CI run
Description of changes:
When the
inputLengthin the stream tests is equal or less than 8, thebufferSizeparameter gets set to 0 which, due to how the InputStreamSubscriber is implemented, becomes an AssertionError later on.The easiest fix is to set the the bufferSize to 1 in BoundedStreamBufferer; this retains the spirit of the utility, which is to read the stream chunk by chunk such that the entire stream isn't read all at once.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: