Skip to content

feat(toolkit-lib): report hotswap messages into a message span #247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 18, 2025

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 18, 2025

Requested by early toolkit-lib users, all hotswap messages are now reported into span. Structured data reported for start and end is intentionally limited and will be extended further in future.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 18, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team March 18, 2025 14:00
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 96.81529% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.44%. Comparing base (ec93ebd) to head (e2832da).

Files with missing lines Patch % Lines
...ckages/aws-cdk/lib/api/deployments/deploy-stack.ts 92.30% 3 Missing ⚠️
...aws-cdk/lib/api/deployments/hotswap-deployments.ts 98.64% 0 Missing and 1 partial ⚠️
...ckages/aws-cdk/lib/api/hotswap/lambda-functions.ts 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #247      +/-   ##
==========================================
+ Coverage   85.27%   85.44%   +0.17%     
==========================================
  Files         212      212              
  Lines       36037    36123      +86     
  Branches     4561     4582      +21     
==========================================
+ Hits        30729    30865     +136     
+ Misses       5161     5105      -56     
- Partials      147      153       +6     
Flag Coverage Δ
suite.unit 85.44% <96.81%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: github-actions <[email protected]>
@mrgrain mrgrain added the pr/exempt-integ-test Skips the integ test steps if set. label Mar 18, 2025
@aws-cdk-automation aws-cdk-automation added this pull request to the merge queue Mar 18, 2025
Merged via the queue into main with commit fe143da Mar 18, 2025
11 checks passed
@aws-cdk-automation aws-cdk-automation deleted the mrgrain/hotswap-spans branch March 18, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2 pr/exempt-integ-test Skips the integ test steps if set.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants