@aws-cdk/aws-s3: Unable to delete the existing S3 event notifications

[sarangarav]

Describe the bug

I'm facing an issue while trying to delete the existing S3 event notifications.

The problem arises with S3 bucket event notification handler Lambda(AWS CloudFormation handler for "Custom::S3BucketNotifications" resources (@aws-cdk/aws-s3)), where it fails and reports an error: when calling the PutBucketNotificationConfiguration operation: Configuration is ambiguously defined. Cannot have overlapping suffixes in two rules if the prefixes are overlapping for the same event type.

Custom event notification handler reference : https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/custom-resource-handlers/lib/aws-s3/notifications-resource-handler/index.py

The issue is likely related to the change: 37be7b9

The offending line is Line 39 - we are updating the ID of a JSON object, but the ID is inside of that object when it comes from outside. (https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/custom-resource-handlers/lib/aws-s3/notifications-resource-handler/index.py#L39)

Expected Behavior

Should delete the existing event notifications

Current Behavior

Unable to delete the existing filters:
Error: when calling the PutBucketNotificationConfiguration operation: Configuration is ambiguously defined. Cannot have overlapping suffixes in two rules if the prefixes are overlapping for the same event type.

Reproduction Steps

1. Add few event notifications
2. Remove some of the the added notifications.
   Please find the example stack attached to reproduce the issue.
   s3-event-notifications.txt

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.124.0

Framework Version

No response

Node.js Version

v20.11.0

OS

Linux

Language

TypeScript

Language Version

No response

Other information

No response

[pahud]

Custom event notification handler reference
I am getting a 404 from this link.

Are you able to provide a minimal reproducible code snippets that we can simply copy/paste to reproduce this issue in our environment? That would be very helpful if we share the same code snippets. Thank you.

[github-actions]

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[gkaskonas]

Hi, we are getting this error everytime we update the lambda target.

  import { Function as Handler } from "aws-cdk-lib/aws-lambda";
  ...
  const handler = Handler.fromFunctionArn(stack, "Handler", stackLocalArn);
  const bucket = Bucket.fromBucketName(stack, "Bucket", bucketName);
  bucket.addEventNotification(EventType.OBJECT_CREATED_PUT, new LambdaDestination(handler));
  return stack;

Every time stackLocalArn is updated the stack update fails with this error

Received response status [FAILED] from custom resource. Message returned: Error: An error occurred (InvalidArgument) when calling the PutBucketNotificationConfiguration operation: Configurations overlap. Configurations on the same bucket cannot share a common event type.. See the details in CloudWatch Log Stream: 2024/01/29/[$LATEST]099d50dec4ab44dcb5be29f1d1b6e13c (RequestId: 9582e198-4537-479b-b112-b17761fb58a2)

Why does it try to create a new notification config instead of updating the existing one? We tried deleting the existing notification config and allowing cf to create a new one but as soon as we update the lambda it fails again.

I think this is related to this change 37be7b9

[sarangarav]

Here is the correct code path :

https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/custom-resource-handlers/lib/aws-s3/notifications-resource-handler/index.py

We found out one more issue when we add a S3 event notification to the existing ones causes creation failure.

The issue is likely related to the change: 37be7b9

The offending line is Line 39 - we are updating the ID of a JSON object, but the ID is inside of that object when it comes from outside. (https://github.com/aws/aws-cdk/blob/main/packages/%40aws-cdk/custom-resource-handlers/lib/aws-s3/notifications-resource-handler/index.py#L39)

We can easily reproduce this issue when we try to add a new S3 event notifications on top of existing ones.
Attached the sample test data to reproduce the issue:
test_samples.json

Custom event notification handler reference
I am getting a 404 from this link.

Are you able to provide a minimal reproducible code snippets that we can simply copy/paste to reproduce this issue in our environment? That would be very helpful if we share the same code snippets. Thank you.