-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(eks): support eks with k8s 1.33 #34602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for your review @mazyu36 |
Hi Team, is there any update on this PR for support for 1.33. We are blocked on some workflows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, approved the PR
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thanks for taking a look @leonmk-aws. Can you help reapprove, the latest commit is just to resolve conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approved, edit: seems that there are still conflicts @phuhung273
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thanks @leonmk-aws, conflict fixed. But the new check is failing, I tried |
A new Github action was added that checks if everything is ok with git lfs files, do you have git lfs installed ? If after installing it it and retrying |
Thanks @leonmk-aws for your guidance. Hope thing can go smooth. |
It seems you have solved the LFS issue, which command did you use to fix it (renormalize or lfs migrate) ? I'll add it to our contributing guide as I suspect a lot of people will run into this issue |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
The one you suggested @leonmk-aws |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Relates #34520
Reason for this change
https://aws.amazon.com/about-aws/whats-new/2025/05/amazon-eks-distro-kubernetes-version-1-33/
Description of changes
Describe any new or updated permissions being added
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license