feat(sns): add notExistsCondition method #34712
Conversation
github-actions
bot
added
feature-request
github-actions
bot
added
the
beginning-contributor
jaw111
changed the title
jaw111
changed the title
jaw111
force-pushed
the
34707-sns-subscription-filter-exists
branch
from
cd6ddb2 to
4f4eafd
Compare
aws-cdk-automation
added
the
pr/reviewer-clarification-requested
jaw111
changed the title
github-actions
bot
added
the
effort/small
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
jaw111
force-pushed
the
34707-sns-subscription-filter-exists
branch
from
f5dfe11 to
3ab6c4b
Compare
aws-cdk-automation
removed
the
pr/reviewer-clarification-requested
| denylist: ['white', 'orange'], | ||
| })), | ||
| }), | ||
| price: sns.Filter.filter(sns.SubscriptionFilter.numericFilter({ |
There was a problem hiding this comment.
Clarification Request:
Does it make sense to specify multiple numeric filters that contradict each other? I assume the message has to match all filter rules to be sent to the SQS queue (logic is AND not OR), but the allowed values 100 and 200 will not satisfy the other numeric filters.
There was a problem hiding this comment.
After reading the documentation, it appears the OR logic would apply. This means the filter would match any numeric value due to the greaterThan: 500 and lessThan: 1000 constraints.
So, it depends on what the intended purpose of such an integration test is. Should it just check the CloudFormation stack is built and deployed, or also test the behavior of the filter does what is expected and messages get filtered accordingly to subscribers?
packages/@aws-cdk-testing/framework-integ/test/aws-sns-subscriptions/test/integ.sns-sqs.ts
Show resolved
Hide resolved
jaw111
force-pushed
the
34707-sns-subscription-filter-exists
branch
4 times, most recently
from
e25ebe1 to
b2d43cd
Compare
aws-cdk-automation
added
the
pr/needs-community-review
jaw111
force-pushed
the
34707-sns-subscription-filter-exists
branch
from
b2d43cd to
0143a4c
Compare
… work as expected
jaw111
force-pushed
the
34707-sns-subscription-filter-exists
branch
from
0143a4c to
6c0eb9d
Compare
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #34707
Reason for this change
Set subscription filter with exists
falsefor a property.Description of changes
Add new
notExistsCondition()method.Describe any new or updated permissions being added
None.
Description of how you validated changes
Extended existing integration test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license