Skip to content

feat: report feature flag configuration into Cloud Assembly #34798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 1, 2025

Conversation

vivian12300
Copy link
Contributor

Issue # (if applicable)

N/A

Reason for this change

For the Feature Flag CLI tool feature.

Description of changes

Populated a Feature Flag report that had individual Feature Flag objects with the recommended value, user value, and description. Stored the report into the Cloud Assembly.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Added unit tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@vivian12300 vivian12300 requested a review from a team as a code owner June 24, 2025 05:28
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Jun 24, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team June 24, 2025 05:28
@github-actions github-actions bot added the p2 label Jun 24, 2025
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Jun 24, 2025
@vivian12300 vivian12300 changed the title feat(feature flag): create a feature flag report feat: create a feature flag report Jun 24, 2025
@rix0rrr rix0rrr self-assigned this Jun 25, 2025
@rix0rrr rix0rrr added pr-linter/exempt-readme The PR linter will not require README changes pr-linter/exempt-integ-test The PR linter will not require integ test changes labels Jun 25, 2025
@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 25, 2025

I have exempted readmes and integ tests, since there is nothing user facing in here that shows up in the API or in CloudFormation templates. We still need unit tests, of course!

@aws-cdk-automation aws-cdk-automation dismissed their stale review June 25, 2025 06:47

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@rix0rrr rix0rrr force-pushed the feature-flag-report branch from 1383fda to df23cc1 Compare June 26, 2025 07:01
@rix0rrr rix0rrr changed the title feat: create a feature flag report feat: report feature flag configuration into Cloud Assembly Jul 1, 2025
Copy link
Contributor

mergify bot commented Jul 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3718188
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Copy link
Contributor

mergify bot commented Jul 1, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 76af7dc into aws:main Jul 1, 2025
18 checks passed
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants