chore: improve performance#1286
Merged
Merged
Conversation
Avoid slice
and a few other things
seebees
reviewed
Apr 6, 2025
Contributor
seebees
left a comment
seebees
left a comment
There was a problem hiding this comment.
Looks good, but a lot of this is me, so I'll leave it to someone else to approve :)
| const KEYWRAP_ENC_INFO := UTF8.EncodeAscii("AWS_MPL_INTERMEDIATE_KEYWRAP_ENC") | ||
| const KEYWRAP_MAC_INFO : UTF8.ValidUTF8Bytes := | ||
| var s := [0x41, 0x57, 0x53, 0x5f, 0x4d, 0x50, 0x4c, 0x5f, 0x49, 0x4e, 0x54, 0x45, 0x52, 0x4d, 0x45, 0x44, 0x49, 0x41, 0x54, 0x45, 0x5f, 0x4b, 0x45, 0x59, 0x57, 0x52, 0x41, 0x50, 0x5f, 0x4d, 0x41, 0x43]; | ||
| assert s == UTF8.EncodeAscii("AWS_MPL_INTERMEDIATE_KEYWRAP_MAC"); |
Contributor
There was a problem hiding this comment.
Nice, I like the assert to tell me what it should be.
rishav-karanjit
pushed a commit
that referenced
this pull request
Jun 17, 2025
## [1.11.0](v1.10.1...v1.11.0) (2025-06-17) ### Fixes -- All Languages * **dafny:** bump Dafny libraries for JSON fix ([#1517](#1517)) ([d8679e5](d8679e5)) ### Maintenance -- All Languages * **dafny:** BK fix to extract encryption context for branch key materials ([#1523](#1523)) ([95856ac](95856ac)) * **dafny:** don't recalculate RSA key on every decrypt ([#1448](#1448)) ([f318912](f318912)) * **dafny:** Make HasSubString generic ([#1549](#1549)) ([6a1017f](6a1017f)) * **dafny:** more using uint64 instead of nat ([#1490](#1490)) ([571e3c5](571e3c5)) * **dafny:** store privateKey in RawRSAKeyring because some Java code needs it ([#1450](#1450)) ([1c29322](1c29322)) * **dafny:** support for memory size constraints ([#1481](#1481)) ([8d2c2b5](8d2c2b5)) * **dafny:** update UInt and MemoryMath as needed for DB-ESDK ([#1488](#1488)) ([49e596b](49e596b)) ### Maintenance -- Java * **java:** migrate to Nexus Central for Maven publishing ([#1553](#1553)) ([7d2fcd3](7d2fcd3)) ### Maintenance -- Go * **go:** implement missing MutableMap::content() ([#1519](#1519)) ([f033b91](f033b91)) * **go:** remove print statements from testLotsOfAdding ([#1468](#1468)) ([594383c](594383c)) ### Maintenance -- Rust * **rust:** remove print statements from testLotsOfAdding ([#1469](#1469)) ([9cf1dce](9cf1dce)) * **rust:** update smithy-dafny, use small-int feature ([#1437](#1437)) ([515995e](515995e)) ### Miscellaneous * add MemoryMath to Index.dfy ([#1484](#1484)) ([3196e7d](3196e7d)) * add MPL CI to principal of KmsKeyForRobbieOnly ([#1528](#1528)) ([527f69d](527f69d)) * bump smithy-dafny to latest ([#1375](#1375)) ([d3e7916](d3e7916)) * CFN for Restricted EC ([#1522](#1522)) ([391fa4c](391fa4c)) * CFN for two new roles to prove prefixing/defixing behavior ([#1538](#1538)) ([e810e7d](e810e7d)) * CFN KMS GDK for HV-2 ([#1464](#1464)) ([cfbaa58](cfbaa58)) * **CI:** Allow local testing ([#1371](#1371)) ([fe18948](fe18948)) * **CI:** Fix nightly build (mostly) ([#1540](#1540)) ([362ffc1](362ffc1)) * **CI:** Fix nightly build workflow ([#1541](#1541)) ([48d69eb](48d69eb)) * Create KMS keys for HV1 & HV2 branch keys ([#1419](#1419)) ([2f0696d](2f0696d)) * Create Static Key Store table for storing static branch keys ([#1456](#1456)) ([96b8058](96b8058)) * **dafny:** add tests for multiple utf8 ec entries ([#1424](#1424)) ([131ae58](131ae58)) * **dafny:** restore static test branch key id ([#1404](#1404)) ([377de79](377de79)) * **deps:** Extend supported pyca version range ([#1556](#1556)) ([89f47aa](89f47aa)) * improve performance ([#1286](#1286)) ([d808fd8](d808fd8)) * install polymorph dependencies in github workflows ([#1514](#1514)) ([eb68525](eb68525)) * **Python:** bump pyca to 44.0 ([#1555](#1555)) ([4f4cd87](4f4cd87)) * resolve rust warning ([#1394](#1394)) ([e2fe1a4](e2fe1a4)) * specify language in commits ([#1382](#1382)) ([ccd56cf](ccd56cf))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.