chore(dafny): add method to Mutate to HV2 without wiring #1445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishav-karanjit
changed the title
Closed
rishav-karanjit
commented
Apr 15, 2025
| return Success(mutatedItem); | ||
| } | ||
|
|
||
| method MutateToHV2( |
Member
Author
There was a problem hiding this comment.
To mutate to hv-2 we do:
- Decrypt the branch key
- Modify the Branch Key Context (BKC) according to the Mutation (EC, KMS-ARN, HV)
- Calculate the BKC Digest with the modified BKC
- Pack and Encrypt the Branch Key Item
rishav-karanjit
commented
Apr 15, 2025
AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStoreAdmin/src/Mutations.dfy
Show resolved
Hide resolved
josecorella
previously approved these changes
Apr 15, 2025
| var crypto? := HvUtils.ProvideCryptoClient(); | ||
| if (crypto?.Failure?) { | ||
| var e := Types.KeyStoreAdminException( | ||
| message := "Local Cryptography error: " + |
Contributor
There was a problem hiding this comment.
the message is misleading - this just means you failed to create a client not that a crypto related operation failed.
Member
Author
There was a problem hiding this comment.
I replaced it with "Creation of internal AtomicPrimitivesClient failed:"
Contributor
|
@rishav-karanjit and @josecorella, I noticed you are updating the smithy model files. |
josecorella
reviewed
Apr 16, 2025
AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStoreAdmin/src/Mutations.dfy
Show resolved
Hide resolved
josecorella
previously approved these changes
Apr 16, 2025
Creation of internal AtomicPrimitivesClient failed -> Failed to create internal AtomicPrimitivesClient: Co-authored-by: José Corella <[email protected]>
josecorella
approved these changes
Apr 16, 2025
texastony
pushed a commit
that referenced
this pull request
May 21, 2025
texastony
pushed a commit
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Adds
MutateToHV2which is not yet wired to mutation logic.Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.