chore(java): add examples for mutation to hv-2 #1477
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishav-karanjit
changed the title
This reverts commit 055ffaf.
rishav-karanjit
commented
Apr 25, 2025
...ain/java/software/amazon/cryptography/example/hierarchy/mutations/MutationResumeExample.java
Outdated
Show resolved
Hide resolved
rishav-karanjit
commented
Apr 25, 2025
...va/software/amazon/cryptography/example/hierarchy/mutations/MutationSystemKeyKMSExample.java
Outdated
Show resolved
Hide resolved
rishav-karanjit
commented
Apr 25, 2025
...rc/main/java/software/amazon/cryptography/example/hierarchy/mutations/MutationsProvider.java
Outdated
Show resolved
Hide resolved
rishav-karanjit
commented
Apr 25, 2025
Examples/java/src/test/java/software/amazon/cryptography/example/hierarchy/ExampleTests.java
Outdated
Show resolved
Hide resolved
rishav-karanjit
commented
Apr 25, 2025
Examples/java/src/test/java/software/amazon/cryptography/example/hierarchy/ExampleTests.java
Outdated
Show resolved
Hide resolved
rishav-karanjit
commented
Apr 25, 2025
Examples/java/src/test/java/software/amazon/cryptography/example/hierarchy/ExampleTests.java
Outdated
Show resolved
Hide resolved
rishav-karanjit
changed the title
rishav-karanjit
changed the title
rishav-karanjit
commented
Apr 25, 2025
Examples/java/src/test/java/software/amazon/cryptography/example/hierarchy/ExampleTests.java
Show resolved
Hide resolved
…le/hierarchy/ExampleTests.java
Member
Author
rishav-karanjit
changed the title
rishav-karanjit
changed the title
texastony
previously approved these changes
Apr 28, 2025
Comment on lines
40
to
43
| @Nonnull AwsKms terminalAwsKms, | ||
| @Nullable HierarchyVersion terminalHierarchyVersion, | ||
| @Nonnull SystemKey systemKey, | ||
| @Nullable KeyStoreAdmin admin |
Contributor
There was a problem hiding this comment.
Suggestion: Keep your required args and your non-required args in groups.
Honestly, Smithy is correct, parameters should never be set by argument ordering,
but Java predates Smithy.
Suggested change
| @Nonnull AwsKms terminalAwsKms, | |
| @Nullable HierarchyVersion terminalHierarchyVersion, | |
| @Nonnull SystemKey systemKey, | |
| @Nullable KeyStoreAdmin admin | |
| @Nonnull AwsKms terminalAwsKms, | |
| @Nonnull SystemKey systemKey, | |
| @Nullable HierarchyVersion terminalHierarchyVersion, | |
| @Nullable KeyStoreAdmin admin |
.../software/amazon/cryptography/example/hierarchy/mutations/MutationDecryptEncryptExample.java
Outdated
Show resolved
Hide resolved
| @Nullable SystemKey systemKey, | ||
| @Nullable KeyStoreAdmin admin | ||
| @Nullable KeyStoreAdmin admin, | ||
| final boolean doNotVersion |
Comment on lines
+119
to
+120
| @Nullable final HierarchyVersion terminalHVersion, | ||
| @Nullable final Boolean doNotVersion |
Contributor
There was a problem hiding this comment.
Praise: Here, Boolean is used, which does support Null, and these are the final values, so this is all correct!
Co-authored-by: Tony Knapp <[email protected]>
…om/aws/aws-cryptographic-material-providers-library into rishav/hv-2/M4/addMutationExamples
texastony
previously approved these changes
Apr 28, 2025
texastony
approved these changes
Apr 28, 2025
texastony
pushed a commit
that referenced
this pull request
May 21, 2025
texastony
pushed a commit
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.