chore(dafny): BKSA Tests for Incomplete Mutations can be recovored #1501
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imabhichow
force-pushed
the
imabhichow/hv-2/test-plan-coverage
branch
from
d2e1750 to
ca04337
Compare
imabhichow
force-pushed
the
imabhichow/hv-2/test-plan-coverage
branch
from
1fbc5cb to
7b71aee
Compare
josecorella
reviewed
May 8, 2025
| doNotVersion := doNotVersionOnMutate | ||
| ); | ||
|
|
||
| // Uncomment to run tests for other mutations |
Contributor
There was a problem hiding this comment.
should these tests not run?
Contributor
Author
There was a problem hiding this comment.
We could do these tests, however I believe we have previously tested all combinations in the End-End round trip.
I believe that only one combination may be enough to prove for the Halted Mutations tests.
If you think otherwise we should test remaining combinations as well, I will uncomment the remaining test cases.
texastony
reviewed
May 9, 2025
AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStore/test/Fixtures.dfy
Show resolved
Hide resolved
AwsCryptographicMaterialProviders/dafny/AwsCryptographyKeyStore/test/TestLyingBranchKey.dfy
Show resolved
Hide resolved
...aterialProviders/dafny/AwsCryptographyKeyStoreAdmin/test/Mutations/TestMutationHappyPath.dfy
Show resolved
Hide resolved
...aterialProviders/dafny/AwsCryptographyKeyStoreAdmin/test/Mutations/TestMutationHappyPath.dfy
Outdated
Show resolved
Hide resolved
...aterialProviders/dafny/AwsCryptographyKeyStoreAdmin/test/Mutations/TestMutationHappyPath.dfy
Show resolved
Hide resolved
texastony
reviewed
May 9, 2025
Contributor
texastony
left a comment
texastony
left a comment
There was a problem hiding this comment.
There is a factual error in the comments that we should correct.
...aterialProviders/dafny/AwsCryptographyKeyStoreAdmin/test/Mutations/TestMutationHappyPath.dfy
Show resolved
Hide resolved
Co-authored-by: Tony Knapp <[email protected]>
texastony
approved these changes
May 9, 2025
texastony
pushed a commit
that referenced
this pull request
May 21, 2025
texastony
pushed a commit
that referenced
this pull request
May 21, 2025
texastony
pushed a commit
that referenced
this pull request
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.