Skip to content

Conversation

@texastony
Copy link
Contributor

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

<type>(dafny/java/python/dotnet/go/rust): <description>

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@texastony texastony marked this pull request as ready for review May 16, 2025 19:00
@texastony texastony requested a review from a team as a code owner May 16, 2025 19:01
@texastony texastony force-pushed the texastony/hv-2/ensure-defix branch from e65b424 to 1e4c488 Compare May 16, 2025 19:11
|BLANKISH|-1,
n requires 0 <= n <= |BLANKISH|-1 => Structure.ENCRYPTION_CONTEXT_PREFIX + BLANKISH[n] + JOHN)

method {:test} /* {:verify false} */ TestRemovePrefix() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
method {:test} /* {:verify false} */ TestRemovePrefix() {
method {:test} TestRemovePrefix() {

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will fix this another time. Want to get this in for some other testing.

@texastony texastony merged commit 7e0ed9e into hv-2/hv-2 May 16, 2025
112 of 114 checks passed
@texastony texastony deleted the texastony/hv-2/ensure-defix branch May 16, 2025 21:53
texastony added a commit that referenced this pull request May 21, 2025
I am By passing a CI failure in Java .
It is with Mutations, one of the three Java tests failed:
```
TestMutateHierarchyVersion.TestHV1toHV2HappyCaseDecryptEncrypt: FAILED
	dafny/AwsCryptographyKeyStoreAdmin/test/Mutations/TestMutationHappyPath.dfy(313,6): Actual customer send EC and expected customer send EC did not match.
```
We should look into this...
texastony added a commit that referenced this pull request May 21, 2025
I am By passing a CI failure in Java .
It is with Mutations, one of the three Java tests failed:
```
TestMutateHierarchyVersion.TestHV1toHV2HappyCaseDecryptEncrypt: FAILED
	dafny/AwsCryptographyKeyStoreAdmin/test/Mutations/TestMutationHappyPath.dfy(313,6): Actual customer send EC and expected customer send EC did not match.
```
We should look into this...
texastony added a commit that referenced this pull request May 21, 2025
I am By passing a CI failure in Java .
It is with Mutations, one of the three Java tests failed:
```
TestMutateHierarchyVersion.TestHV1toHV2HappyCaseDecryptEncrypt: FAILED
	dafny/AwsCryptographyKeyStoreAdmin/test/Mutations/TestMutationHappyPath.dfy(313,6): Actual customer send EC and expected customer send EC did not match.
```
We should look into this...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants