test(Dafny): BKS Integ Test ensure EncCtx is prefixed/unprefixed as expected #1544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texastony
force-pushed
the
texastony/hv-2/test-JSON-Encoding-of-Mutations-Supports-Escape-Characters
branch
from
a3e5c0a to
a5d979d
Compare
Base automatically changed from
texastony/hv-2/test-JSON-Encoding-of-Mutations-Supports-Escape-Characters
to
hv-2/hv-2
May 28, 2025 21:40
…ed/unprefixed as expected
texastony
force-pushed
the
texastony/hv-2/test-bks-ec-prefixed-defixed-as-expected
branch
from
dcdf298 to
0cbccb5
Compare
Member
There was a problem hiding this comment.
Non blocking comment: createHV1, checkBranchKey and mutateToHV2 is very identical to the functions in TestMutationsWithEscapeCharactersInEC.java. The only thing that different is the EC. We could had made one helper function and call helper function here and in TestMutationsWithEscapeCharactersInEC.java.
Contributor
Author
There was a problem hiding this comment.
Yes.
I thought about that.
Or made collapse all three of these class into a super and it's extensions.
But ultimately, the methods here are calling already created helper methods.
I am for abstraction, but not mega abstraction.
I think this walks a good balance.
texastony
deleted the
texastony/hv-2/test-bks-ec-prefixed-defixed-as-expected
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Integ Tests use CFN Roles created by this PR to ensure that the Branch Key Store correctly handles EC.
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.