chore: Rename AtomicPrimitives Dafny module name#589
Merged
Conversation
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
lucasmcdonald3
temporarily deployed
to
Duvet CI
GitHub Actions
Inactive
texastony
reviewed
Aug 25, 2024
Contributor
There was a problem hiding this comment.
cd /workplace/aws-database-encryption-sdk-dynamodb-java/DynamoDbEncryption
grep "Aws.Cryptography.Primitives" runtimes/java/src/main/dafny-generated/**/*.java
# no hits
grep "software.amazon.cryptography.primitives" runtimes/java/src/main/dafny-generated/**/*.java
# many hits, but they all reflect the "extern" name, not the Modules name, so this non-breaking.
ajewellamz
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Change the Dafny name for this client to AtomicPrimitives.
Both Go and Python will reference every Local Service client module name as the localService trait's sdkId value.
The client module name is the same as the sdkId in almost all cases, except Primitives.
This changes Primitives' Dafny name to align with its localService trait sdkId value.
(There is no change for Java/NET compiled code here because this module is an extern in those languages.)
Downstream builds:
This verifies that with ESDK/DBESDK can build with these changes. (Downstream libraries need to make similar changes, but we can't merge these into the respective main branches yet, and we should only pin those libraries to released versions of the MPL.)
Squash/merge commit message, if applicable:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.