Skip to content

[DRAFT] Proposed Python release changes, partial #680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 9, 2024

Conversation

lucasmcdonald3
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 commented Sep 6, 2024

Description of changes:

Changes from ESDK release process

  • No park. This seems like more effort to set up for a package without setup.py. This is a 2-way door, we can come back and add this later.
  • validate tests involve installing the package from PyPI and running tests against the published package.
    • ESDK's validate tested against a downstream dependency (busy-engineers-guide), but not every MPL subproject has a separate downstream dependency. Only the MPL-Core does. For the MPL-Core, this will also test against the ESDK as a downstream dependency.
  • Use pyproject.toml poetry configs instead of .txt files

I only made changes for MPL-Core and Primitives as a proof of concept for other subprojects.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

github-actions bot commented Sep 6, 2024

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

Copy link

github-actions bot commented Sep 6, 2024

Detected changes to the release files or to the check-files action

Copy link

github-actions bot commented Sep 6, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link

github-actions bot commented Sep 6, 2024

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

Copy link

github-actions bot commented Sep 6, 2024

Detected changes to the release files or to the check-files action

Copy link

github-actions bot commented Sep 6, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link

github-actions bot commented Sep 6, 2024

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

Copy link

github-actions bot commented Sep 6, 2024

Detected changes to the release files or to the check-files action

Copy link

github-actions bot commented Sep 6, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

Copy link

github-actions bot commented Sep 9, 2024

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

Copy link

github-actions bot commented Sep 9, 2024

Detected changes to the release files or to the check-files action

Copy link

github-actions bot commented Sep 9, 2024

Changes to the release files or the check-files action requires 2 approvals from CODEOWNERS

@lucasmcdonald3 lucasmcdonald3 merged commit 4ff52ad into lucmcdon/python-mpl-v2 Sep 9, 2024
30 of 54 checks passed
@lucasmcdonald3 lucasmcdonald3 deleted the python-release branch October 5, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant