Skip to content

chore: test smithy diff #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
josecorella merged 8 commits into from
Sep 19, 2024
Merged

chore: test smithy diff #740

josecorella merged 8 commits into from
Sep 19, 2024

Conversation

@josecorella
Copy link
Contributor

@josecorella josecorella commented Sep 19, 2024

Issue #, if available:

Description of changes:

Squash/merge commit message, if applicable:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

josecorella
josecorella commented Sep 19, 2024
View reviewed changes
Copy link
Contributor Author

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

lucasmcdonald3
lucasmcdonald3 reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

josecorella
josecorella commented Sep 19, 2024
View reviewed changes
Copy link
Contributor Author

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

josecorella
josecorella commented Sep 19, 2024
View reviewed changes
Copy link
Contributor Author

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

another test

texastony
texastony previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

josecorella
josecorella commented Sep 19, 2024
View reviewed changes
Copy link
Contributor Author

@josecorella josecorella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024 •
edited by josecorella
Loading

@josecorella and, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@josecorella josecorella marked this pull request as ready for review September 19, 2024 22:49
@josecorella josecorella requested a review from a team as a code owner September 19, 2024 22:49
lucasmcdonald3
lucasmcdonald3 previously approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@lucasmcdonald3 lucasmcdonald3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fake approval, not merging

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024

@lucasmcdonald3, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony
texastony previously approved these changes Sep 19, 2024
View reviewed changes
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024

@josecorella and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024

@josecorella and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

texastony
texastony reviewed Sep 19, 2024
View reviewed changes
Copy link
Contributor

@texastony texastony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am commenting on a PR.
What happens?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 19, 2024

@josecorella and @texastony, I noticed you are updating the smithy model files.
Does this update need new or updated javadoc trait documentation?
Are you adding constraints inside list, map or union? Do you know about this issue: smithy-lang/smithy-dafny#491?

@josecorella josecorella merged commit 36ede26 into main Sep 19, 2024
lucasmcdonald3 pushed a commit that referenced this pull request Sep 24, 2024
@josecorella @texastony @lucasmcdonald3
chore: test smithy diff (#740)
e92f735 
Co-authored-by: Tony Knapp <[email protected]>
lucasmcdonald3 pushed a commit to lucasmcdonald3/aws-cryptographic-material-providers-library that referenced this pull request Sep 26, 2024
@josecorella @texastony @lucasmcdonald3
chore: test smithy diff (aws#740)
9faa946 
Co-authored-by: Tony Knapp <[email protected]>
lucasmcdonald3 pushed a commit to lucasmcdonald3/aws-cryptographic-material-providers-library that referenced this pull request Oct 1, 2024
@josecorella @texastony @lucasmcdonald3
chore: test smithy diff (aws#740)
3a8ed3b 
Co-authored-by: Tony Knapp <[email protected]>
ajewellamz pushed a commit that referenced this pull request Dec 18, 2024
@RitvikKapila
chore(pr-ci-rust): fix by updating Dafny version (#740)
caef779
@josecorella josecorella deleted the jocorell/test-smithy-diff branch April 3, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@texastony texastony texastony approved these changes

@lucasmcdonald3 lucasmcdonald3 lucasmcdonald3 left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@josecorella @texastony @lucasmcdonald3