Skip to content

chore(Go): Add interop test with CI #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 17, 2025

Conversation

rishav-karanjit
Copy link
Member

@rishav-karanjit rishav-karanjit commented Mar 13, 2025

Issue #, if available:

Description of changes:
Merging into Golang/DynamoDbEncryptionModule then Golang/DynamoDbEncryptionModule into Golang/reviewed

  • Add interop test for DB-ESDK Go
  • CI for other runtimes are commented to return noise and avoid work to change from mac to ubuntu for now
  • CI TODO is expected to fail because of new TODO we have in code.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@rishav-karanjit rishav-karanjit changed the title Test vectors chore(Go): Add interop test with CI Mar 13, 2025
@rishav-karanjit rishav-karanjit marked this pull request as ready for review March 14, 2025 16:34
@rishav-karanjit rishav-karanjit requested a review from a team as a code owner March 14, 2025 16:34

const DEFAULT_KEYS : string := "../../../submodules/MaterialProviders/TestVectorsAwsCryptographicMaterialProviders/dafny/TestVectorsAwsCryptographicMaterialProviders/test/keys.json"
// TODO: Add extern for DEFAULT_KEYS
const DEFAULT_KEYS : string := "../../../../submodules/MaterialProviders/TestVectorsAwsCryptographicMaterialProviders/dafny/TestVectorsAwsCryptographicMaterialProviders/test/keys.json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also write a Dafny function like
if OsLang.GetLanguageShort() == "Go" then
"something/keys.json"
else
"something_else/keys.json"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I did not know I could get name of transpiling language in dafny.

I will look into it later.

@rishav-karanjit rishav-karanjit merged commit 7b8699f into Golang/DynamoDbEncryptionModule Mar 17, 2025
13 of 14 checks passed
@rishav-karanjit rishav-karanjit deleted the Golang/TestVectors branch March 17, 2025 17:31
rishav-karanjit added a commit that referenced this pull request Mar 19, 2025
* chore(Go): Add DynamoDBEncryption Module 

* chore(Go): Add interop test with CI  (#1721)

* chore(Go): Add KMS and raw AES keyring example with CI (#1726)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants