-
Notifications
You must be signed in to change notification settings - Fork 15
refactor(Go): Update examples to use utils and fix var name #1860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c2ba06e
refactor examples
rishav-karanjit a38f145
comments
rishav-karanjit 878b254
Comment TODOs
rishav-karanjit ac1d835
Merge branch 'Golang/reviewed' into Golang/Examples/refactoring
rishav-karanjit e401c9a
itemencryptor SED
rishav-karanjit 957b3a2
makefile
rishav-karanjit e078b6b
makefile
rishav-karanjit a86ce02
makefile
rishav-karanjit d539ba7
Add extern
rishav-karanjit d21ce81
auto commit
rishav-karanjit b62f592
Merge branch 'Golang/reviewed' into Golang/Examples/refactoring
rishav-karanjit 78d480c
# TODO: Uncomment this
rishav-karanjit 8272eb5
Merge branch 'Golang/Examples/refactoring' of https://github.com/aws/…
rishav-karanjit f2dda6b
Revert "Merge branch 'Golang/Examples/refactoring' of https://github.…
rishav-karanjit File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixing this to make Go idiomatic as in https://go.dev/wiki/CodeReviewComments#initialisms