convert all attrs classes to use custom init methods to enable mypy to work #44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #4
Description of changes:
Because mypy cannot currently correctly read the init profile of an attrs-generated class, in order for mypy to work correctly we need to build out these
__init__
shims. These enable mypy integration at the cost of making the codebase a bit messier. Once mypy and attrs can play well together we'll be removing these shims, so they should do literally nothing except:__attrs_post_init__
function (this function is used with attrs-generated classes for any custom logic that needs to happen at init time)By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.