-
Notifications
You must be signed in to change notification settings - Fork 229
Powershell changes #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+141
−54
Merged
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6727a94
Check for OS-Bitness rather than Processor Architecture
rahulrajaram 6db1e26
Extract logic to determine Python installation URL into a function
rahulrajaram 307c0db
Modify verbiage indicating Python will be installed silently
rahulrajaram 74407d5
Rename $python -> $PythonInstaller in install-python.ps1
rahulrajaram a90eb41
Exit install-python.ps1 with non-0 code if MSI download fails
rahulrajaram ee21ee5
Extract logic to install Python into a function
rahulrajaram 9079800
Avoid closing existing shell after installation completion
rahulrajaram c27746b
Bring up Python MSI rather than install in the background
rahulrajaram d40f64d
Remove previously downloaded Python MSI exe before new attempt to dow…
rahulrajaram 9576d5c
Update PATH current session after installation
rahulrajaram 8078c03
Rename Download-Python -> Get-PythonMSI
rahulrajaram 59bb41e
Rename Assert-IsPythonRequired -> Get-PythonExecutable/Change return …
rahulrajaram b3b5433
Handle user-triggered exits from the installer specially
rahulrajaram 751b53e
Rename install-python.ps1 -> .\scripts\install-python.ps1
rahulrajaram e71f0c1
Create a function to echo step titles
rahulrajaram ea539f7
Highlight success/failure messages printed by install-python.ps1 in g…
rahulrajaram db8262f
Install virtualenv after completing python installation
rahulrajaram 69759fe
Create a PS1/BAT script to install Python and the EBCLI
rahulrajaram 7cb76dc
Exit Python installation script following installation failures
rahulrajaram File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this fails, returning $True doesn't make sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is eliminate in a future commit.