Skip to content

fix: remove unused symlinking in esbuild workflow #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 28, 2023
Merged

fix: remove unused symlinking in esbuild workflow #432

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion aws_lambda_builders/workflows/nodejs_npm_esbuild/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,6 @@ def _accelerate_workflow_actions(
actions += [
esbuild_with_deps,
MoveDependenciesAction(source_dir, scratch_dir, self.dependencies_dir),
LinkSourceAction(self.dependencies_dir, scratch_dir),
]
else:
# Auto dependency layer enabled, first build
Expand Down
3 changes: 1 addition & 2 deletions tests/unit/workflows/nodejs_npm_esbuild/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,14 +265,13 @@ def test_workflow_sets_up_esbuild_actions_with_download_dependencies_and_depende
experimental_flags=[],
)

self.assertEqual(len(workflow.actions), 6)
self.assertEqual(len(workflow.actions), 5)

self.assertIsInstance(workflow.actions[0], CopySourceAction)
self.assertIsInstance(workflow.actions[1], NodejsNpmInstallAction)
self.assertIsInstance(workflow.actions[2], CleanUpAction)
self.assertIsInstance(workflow.actions[3], EsbuildBundleAction)
self.assertIsInstance(workflow.actions[4], MoveDependenciesAction)
self.assertIsInstance(workflow.actions[5], LinkSourceAction)

def test_workflow_sets_up_esbuild_actions_with_download_dependencies_and_dependencies_dir_no_combine_deps(self):
workflow = NodejsNpmEsbuildWorkflow(
Expand Down