remove dialog action from lex event (#240)

* remove dialog action from lex event

* gofmt

* fix type in TestLexResponseMalformedJson

Co-authored-by: Bryan Moffatt <[email protected]>
Co-authored-by: Bryan Moffatt <[email protected]>

Author: 3 people

events/lex.go

@@ -11,7 +11,8 @@ type LexEvent struct {
 	OutputDialogMode   string                  `json:"outputDialogMode,omitempty"`
 	CurrentIntent      *LexCurrentIntent       `json:"currentIntent,omitempty"`
 	AlternativeIntents []LexAlternativeIntents `json:"alternativeIntents,omitempty"`
-	DialogAction       *LexDialogAction        `json:"dialogAction,omitempty"`
+	// Deprecated: the DialogAction field is never populated by Lex events
+	DialogAction *LexDialogAction `json:"dialogAction,omitempty"`
 }
 
 type LexBot struct {
@@ -77,5 +78,4 @@ type Attachment struct {
 func (h *LexEvent) Clear() {
 	h.Bot = nil
 	h.CurrentIntent = nil
-	h.DialogAction = nil
 }

events/lex_test.go

@@ -9,27 +9,41 @@ import (
 )
 
 func TestLexEventMarshaling(t *testing.T) {
-	tests := []struct {
-		filePath string
-	}{{"./testdata/lex-response.json"}, {"./testdata/lex-event.json"}}
+	inputJSON := test.ReadJSONFromFile(t, "./testdata/lex-event.json")
 
-	for _, te := range tests {
-		inputJSON := test.ReadJSONFromFile(t, te.filePath)
+	var inputEvent LexEvent
+	if err := json.Unmarshal(inputJSON, &inputEvent); err != nil {
+		t.Errorf("could not unmarshal event. details: %v", err)
+	}
 
-		var inputEvent LexEvent
-		if err := json.Unmarshal(inputJSON, &inputEvent); err != nil {
-			t.Errorf("could not unmarshal event. details: %v", err)
-		}
+	outputJSON, err := json.Marshal(inputEvent)
+	if err != nil {
+		t.Errorf("could not marshal event. details: %v", err)
+	}
 
-		outputJSON, err := json.Marshal(inputEvent)
-		if err != nil {
-			t.Errorf("could not marshal event. details: %v", err)
-		}
+	assert.JSONEq(t, string(inputJSON), string(outputJSON))
+}
 
-		assert.JSONEq(t, string(inputJSON), string(outputJSON))
+func TestLexResponseMarshaling(t *testing.T) {
+	inputJSON := test.ReadJSONFromFile(t, "./testdata/lex-response.json")
+
+	var inputEvent LexResponse
+	if err := json.Unmarshal(inputJSON, &inputEvent); err != nil {
+		t.Errorf("could not unmarshal event. details: %v", err)
 	}
+
+	outputJSON, err := json.Marshal(inputEvent)
+	if err != nil {
+		t.Errorf("could not marshal event. details: %v", err)
+	}
+
+	assert.JSONEq(t, string(inputJSON), string(outputJSON))
 }
 
 func TestLexMarshalingMalformedJson(t *testing.T) {
 	test.TestMalformedJson(t, LexEvent{})
 }
+
+func TestLexResponseMalformedJson(t *testing.T) {
+	test.TestMalformedJson(t, LexResponse{})
+}