-
Notifications
You must be signed in to change notification settings - Fork 560
remove dialog action from lex event #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove dialog action from lex event #240
Conversation
Codecov Report
@@ Coverage Diff @@
## master #240 +/- ##
========================================
+ Coverage 74.59% 74.7% +0.1%
========================================
Files 20 20
Lines 681 680 -1
========================================
Hits 508 508
+ Misses 128 127 -1
Partials 45 45
Continue to review full report at Codecov.
|
@bmoffatt, please review |
Hi @artempanko, thanks for this contribution. We're discussing how we can proceed with this kind of request as it breaks our API compatibility. After we have an update, I'll post here. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Codecov Report
@@ Coverage Diff @@
## main #240 +/- ##
==========================================
+ Coverage 72.01% 72.07% +0.06%
==========================================
Files 19 19
Lines 1054 1053 -1
==========================================
Hits 759 759
+ Misses 225 224 -1
Partials 70 70
Continue to review full report at Codecov.
|
rebased and added a deprecation comment that linters will complain about rather than removing the field |
Remove DialogAction from LexEvent according to https://docs.aws.amazon.com/lex/latest/dg/lambda-input-response-format.html#using-lambda-input-event-format and align tests with LexResponse model.