-
Notifications
You must be signed in to change notification settings - Fork 560
Create BatchItemFailure structs for DynamoDB, Kinesis, SQS #410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #410 +/- ##
=======================================
Coverage 71.66% 71.66%
=======================================
Files 19 19
Lines 1041 1041
=======================================
Hits 746 746
Misses 228 228
Partials 67 67 Continue to review full report at Codecov.
|
Thanks! This looks applicable for SQS Partial Batch Failures too! Though it can be used across all 3 event sources, I'm thinking to proactively namespace the structs. eg: define @carlzogh WDYT? |
Absolutely, thanks @bmoffatt - we've found it tricky in the Java events library to rename/cater for different event source types that seem similar at first, so accounting for those explicitly from the get-go is a good idea! |
Doing a pulse check, would love to see
Is there a strategy on |
I split up the structs (and child item failure structs) into different structs per each service (as well as adding SQS) and updated the description/title accordingly. I kept everything in |
LGTM, thanks! |
This change adds the response structs for "reporting batch item failures" documented in:
This is implemented in the Java events SDK as: aws-lambda-java-events/src/main/java/com/amazonaws/services/lambda/runtime/events/StreamsEventResponse.java
I don't know that adding a test here has any value, but happy to add one if you'd like.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.