Skip to content

Fix os compatibility test local builds on arm64 hosts #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2022

Conversation

zsombor-balogh
Copy link
Contributor

Issue #, if available:

Description of changes:
Fix os compatibility tests on arm64 host local builds:

  • update codebuild_build.sh script from upstream to be able to set local_agent_image
  • use arm64 specific local agent image when running on arm64 host
  • extract invocation test logic to a separate script
  • increase invocation timeout when running test on arm64 with x86_64 being emulated (this combination timed out with previous 10 sec configuration)
  • set platform explicitly when running test images to avoid architecture discrepancy warning message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zsombor-balogh zsombor-balogh requested a review from carlzogh May 6, 2022 09:29
Copy link
Contributor

@carlzogh carlzogh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zsombor-balogh!

@zsombor-balogh zsombor-balogh merged commit 06d1ebf into aws:master May 6, 2022
Sordie pushed a commit to Sordie/aws-lambda-java-libs that referenced this pull request May 14, 2022
* Fix os compatibility test local builds on arm64 hosts

* Extract log fetching and clean up to separate scripts
andclt pushed a commit that referenced this pull request Aug 22, 2022
* feat(events): add lex v2 event and response

* fix(events): typo

* feat(serialization): add lex v2 event test

* Ensure at build time that the jni parts of the runtime-interface-client are compiled for the correct architectures

* Update aws-lambda-java-runtime-interface-client.yml

* version bump aws-lambda-java-runtime-interface-client 2.1.0 -> 2.1.1

* Update RELEASE.CHANGELOG.md

* fix: typo

* Update Curl to 7.83.0

* remove invalid link from README (#333)

* Fix os compatibility tests by enabling multi-platform build and testing (#334)

* Fix os compatibility tests by enabling multi-platform build and testing

* Extract environment setup script

* Use correct package name prefix of 'NativeClient' class (#335)

* Fix os compatibility test local builds on arm64 hosts (#338)

* Fix os compatibility test local builds on arm64 hosts

* Extract log fetching and clean up to separate scripts

* feat(events): move lex v2 event test

* chore(events): revert merge failures

* fix: mapping errors

* feat: add sentiment and kendra response

* feat(events): add kendra response to event

* fix(events): provide expected json for tests

* chore(events): add response test

* chore(events): remove cloneable interface and update year

* feat(events): keep slots with null value

Co-authored-by: Bryan Moffatt <[email protected]>
Co-authored-by: Bryan Moffatt <[email protected]>
Co-authored-by: hsukanya <[email protected]>
Co-authored-by: zsombor-balogh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants