Skip to content

Use AWS_LAMBDA_LOG_LEVEL env var to set log level for text format #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

kotyara1005
Copy link
Contributor

Use AWS_LAMBDA_LOG_LEVEL env var to set log level for text format

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kotyara1005
Copy link
Contributor Author

Ping @alex-pewpew @luben

Copy link

@luben luben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kotyara1005 kotyara1005 force-pushed the structured-logging-follow-up branch from 907ed65 to 28d8b48 Compare August 25, 2023 16:23
@kotyara1005 kotyara1005 requested a review from luben August 25, 2023 17:15
Copy link

@luben luben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
So this will not affect in any way the existing functions and will only affect cases where we have AWS_LAMBDA_LOG_LEVEL set and format is not JSON.

@kotyara1005 kotyara1005 force-pushed the structured-logging-follow-up branch from 28d8b48 to d93b082 Compare August 28, 2023 19:38
Copy link
Contributor

@alex-pewpew alex-pewpew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please squash commits

@kotyara1005 kotyara1005 force-pushed the structured-logging-follow-up branch from d93b082 to aed8b59 Compare August 29, 2023 10:31
@briensea briensea merged commit 9efb462 into aws:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants