Control unicode encoding behaviour based on execution environment. #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-pewpew
reviewed
Oct 26, 2023
|
Recommendation is to not implement the features gating abstraction for now to unblock safe version bump, and polish this PR |
alex-pewpew
approved these changes
Oct 27, 2023
| @@ -15,7 +15,10 @@ | |||
| # We also set 'ensure_ascii=False' so that the encoded json contains unicode characters instead of unicode escape sequences | |||
| class Encoder(json.JSONEncoder): | |||
| def __init__(self): | |||
| super().__init__(use_decimal=False, ensure_ascii=False) | |||
| if os.environ.get("AWS_EXECUTION_ENV") in {"AWS_Lambda_python3.12"}: | |||
There was a problem hiding this comment.
Nitpicks:
if os.environ.get("AWS_EXECUTION_ENV") == "AWS_Lambda_python3.12":
to avoid extra set object creation
pushkarchawda
approved these changes
Oct 27, 2023
alex-pewpew
approved these changes
Oct 27, 2023
|
LGTM, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Control unicode encoding behaviour based on execution environment.
Target (OCI, Managed Runtime, both):
Both.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.