Skip to content

Conversation

@sontek
Copy link

@sontek sontek commented May 23, 2022

Description of changes:
The README said we could use 3.7 -> 3.9 but it was only being tested against 3.8. This introduces a tox.ini for local environment testing as well as adds a matrix for every supported python runtime in the github actions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sontek
Copy link
Author

sontek commented Oct 31, 2022

Anything I need to do to get this merged? These tickets are related:

#89
#85

cc @keshayad

@@ -0,0 +1,6 @@
[tox]
envlist = python3.7,python3.8,python3.9,python3.10
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To support different python versions with tox you may use a dependency matrix:
https://tox.wiki/en/latest/example/basic.html#compressing-dependency-matrix

Suggested change
envlist = python3.7,python3.8,python3.9,python3.10
envlist = py{37,38,39,310}

@JonZeolla
Copy link

@sontek this could benefit from a rebase on main (including a deconflict), and addition of 3.6 and 3.11

@sontek sontek closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants