Bump to aws-lc-rs v1.13.0 #758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #758 +/- ##
==========================================
- Coverage 95.80% 92.94% -2.86%
==========================================
Files 61 71 +10
Lines 8143 9813 +1670
Branches 0 9813 +9813
==========================================
+ Hits 7801 9121 +1320
- Misses 342 405 +63
- Partials 0 287 +287 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
changed the title
justsmth
force-pushed
the
aws-lc-rs-v1.13.0
branch
from
3771634 to
b32f67c
Compare
justsmth
force-pushed
the
aws-lc-rs-v1.13.0
branch
4 times, most recently
from
9564307 to
1619859
Compare
justsmth
force-pushed
the
aws-lc-rs-v1.13.0
branch
from
1619859 to
358d832
Compare
justsmth
force-pushed
the
aws-lc-rs-v1.13.0
branch
from
358d832 to
c1fd9b5
Compare
smittals2
reviewed
Apr 1, 2025
| echo 'export PATH="/opt/homebrew/opt/llvm/bin:$PATH"' >> "$GITHUB_ENV" | ||
| echo 'export LIBCLANG_PATH=/opt/homebrew/opt/llvm' >> "$GITHUB_ENV" | ||
| echo 'LIBCLANG_PATH=${{ (matrix.os == 'macos-13' && '/usr/local') || '/opt/homebrew' }}/opt/llvm/lib' >> $GITHUB_ENV | ||
| echo 'LLVM_CONFIG_PATH=${{ (matrix.os == 'macos-13' && '/usr/local') || '/opt/homebrew' }}/opt/llvm/bin/llvm-config' >> $GITHUB_ENV |
There was a problem hiding this comment.
Just curious, why was this change made?
There was a problem hiding this comment.
What we were doing previously was incorrect.
- It was creating environment variables named "export PATH" and "export LIBCLANG_PATH" (instead of "PATH" and "LIBCLANG_PATH").
- On macos-13, the homebrew path is under
/use/localnot '/opt/homebrew'.
smittals2
approved these changes
Apr 1, 2025
skmcgrail
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed:
Remove Kyber, KDF fromunstablemodule #747Include Go source inaws-lc-syscrate #754Align aws-lc-sys v0.28.0 w/ AWS-LC 1.49.0 #757Bump aws-lc-fips-sys to v0.13.5 #760Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.