Skip to content

Add Xmlsec to our CI #2333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 6, 2025
Merged

Add Xmlsec to our CI #2333

merged 10 commits into from
May 6, 2025

Conversation

smittals2
Copy link
Contributor

@smittals2 smittals2 commented Apr 15, 2025

Issues:

2909

Description of changes:

Add xmlsec to our CI

Call-outs:

2 callouts regarding the patch file:

  1. we lower the overall percentage of tests required to succeed with openSSL. Xmlsec verifies the percentage of tests that passed as an additional check. Skipped tests can skew this (and we skip a bunch because of missing features like ossl_store).
  2. 10 tests are commented out in the Xmlsec test suite. These 10 tests all have certs that use MD5 digests. AWS-LC rejects these certs by default. OS level patching of OpenSSL adds support for OPENSSL_ENABLE_MD5_VERIFY to allow validating these certs. We don't support this in AWS-LC. I have verified that these 10 tests pass if we were to start accepting md5 digests.

Testing:

How is this change tested (unit tests, fuzz tests, etc.)? Are there any testing steps to be verified by the reviewer?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.76%. Comparing base (38369db) to head (24319bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2333   +/-   ##
=======================================
  Coverage   78.76%   78.76%           
=======================================
  Files         620      620           
  Lines      107961   107961           
  Branches    15331    15330    -1     
=======================================
+ Hits        85033    85034    +1     
+ Misses      22273    22268    -5     
- Partials      655      659    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@smittals2 smittals2 marked this pull request as ready for review April 23, 2025 21:47
@smittals2 smittals2 requested a review from a team as a code owner April 23, 2025 21:47
@smittals2 smittals2 requested a review from justsmth May 1, 2025 19:53
@smittals2 smittals2 enabled auto-merge (squash) May 2, 2025 22:55
@smittals2 smittals2 merged commit 3fdc0f6 into aws:main May 6, 2025
113 of 114 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants