Add SQSCustomizations #2108
Merged
Add SQSCustomizations #2108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syall
force-pushed
the
sqs-customization
branch
from
982941e to
f12bbbc
Compare
eddy-aws
reviewed
Apr 26, 2023
Contributor
eddy-aws
left a comment
eddy-aws
left a comment
There was a problem hiding this comment.
Approving this change on behalf of the SQS team.
syall
force-pushed
the
sqs-customization
branch
from
f12bbbc to
8223aa4
Compare
lucix-aws
approved these changes
Apr 26, 2023
kstich
approved these changes
Apr 26, 2023
syall
force-pushed
the
sqs-customization
branch
2 times, most recently
from
9ecabb5 to
9a9e9d1
Compare
kstich
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For changes to files under the
/codegen/aws-modelsfolder, and manual edits to autogenerated code (e.g./service/s3/api.go) please create an Issue instead of a PR for those type of changes.N/A.
If the PR addresses an existing bug or feature, please reference it here.
N/A.
Description
Adds a customization to add default traits to the following members and corresponding top-level input synthetic members, to ensure the default trait is always present:
com.amazonaws.sqs#SendMessageRequest$DelaySecondscom.amazonaws.sqs#ChangeMessageVisibilityBatchRequestEntry$VisibilityTimeoutcom.amazonaws.sqs#SendMessageBatchRequestEntry$DelaySecondscom.amazonaws.sqs#ChangeMessageVisibilityRequest$VisibilityTimeoutcom.amazonaws.sqs#ReceiveMessageRequest$WaitTimeSecondscom.amazonaws.sqs#ReceiveMessageRequest$VisibilityTimeoutcom.amazonaws.sqs#ReceiveMessageRequest$MaxNumberOfMessagesTesting
To help speed up the process and reduce the time to merge please ensure that
Allow edits by maintainersis checked before submitting your PR. This will allow the project maintainers to make minor adjustments or improvements to the submitted PR, allow us to reduce the roundtrip time for merging your request.