Skip to content

S3 GetUrlRequest for S3Utiltiies does not support version #2224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abrooksv opened this issue Jan 4, 2021 · 2 comments · Fixed by #2226
Closed

S3 GetUrlRequest for S3Utiltiies does not support version #2224

abrooksv opened this issue Jan 4, 2021 · 2 comments · Fixed by #2226
Labels
feature-request A feature should be added or improved.

Comments

@abrooksv
Copy link
Contributor

abrooksv commented Jan 4, 2021 •
edited
Loading

Describe the Feature

GetUrlRequest should support versions to generate S3 URLs by appending on ?versionId=<version> to it .

The field is missing in the manually modeled GetUrlRequest

Your Environment

  • AWS Java SDK version used:
  • JDK version used:
  • Operating System and version:
@abrooksv abrooksv added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 4, 2021
@abrooksv abrooksv mentioned this issue Jan 4, 2021
Merged
9 tasks
@millems
Copy link
Contributor

millems commented Jan 4, 2021

This shouldn't be hard to implement.

@millems millems removed the needs-triage This issue or PR still needs to be triaged. label Jan 4, 2021
@zoewangg zoewangg mentioned this issue Jan 4, 2021
Merged
13 tasks
@debora-ito debora-ito linked a pull request Jan 4, 2021 that will close this issue
Support versionId in S3Utilities#getUrl #2226
Merged
13 tasks
@github-actions
Copy link

github-actions bot commented Jan 5, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

aws-sdk-java-automation added a commit that referenced this issue Oct 27, 2022
@aws-sdk-java-automation
Merge pull request #2224 from aws/staging/79885027-09e2-43a5-bcb3-073…
cb8c281 
…d672eba38

Pull request: release <- staging/79885027-09e2-43a5-bcb3-073d672eba38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support versionId in S3Utilities#getUrl aws/aws-sdk-java-v2
2 participants
@abrooksv @millems