Skip to content

DynamoDB EnhancedAttributeValue "set" operations should accept sets #3453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 tasks
chrylis opened this issue Sep 30, 2022 · 4 comments · Fixed by #3516
Closed
2 tasks

DynamoDB EnhancedAttributeValue "set" operations should accept sets #3453

chrylis opened this issue Sep 30, 2022 · 4 comments · Fixed by #3516
Assignees
Labels
feature-request A feature should be added or improved.

Comments

@chrylis
Copy link

chrylis commented Sep 30, 2022

Describe the feature

DynamoDB supports "set" types for homogenous multi-valued data, and the EnhancedAttributeValue type provides mapper methods for those (e.g., fromSetOfNumbers). However, the signatures of those methods accept specifically List. Instead, they should accept Collection.

Use Case

I would like to pass an actual Set implementation to fromSetOf*.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

AWS Java SDK version used

2.17.284

JDK version used

AdoptOpenJDK-11.0.11+9

Operating System and version

Gentoo Linux

@chrylis chrylis added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Sep 30, 2022
@yasminetalby yasminetalby self-assigned this Oct 3, 2022
@yasminetalby
Copy link

Hello @chrylis ,

Thank you very much for your submission.
The Set Types (NS, BS and SS type) are all defined as list by the API see hence why the SDK accept list specifically for those method.
This would be more of a service behavior rather than an SDK behavior feature request.

Best,

Yasmine

@yasminetalby yasminetalby added service-api This issue is due to a problem in a service API, not the SDK implementation. response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 3, 2022
@chrylis
Copy link
Author

chrylis commented Oct 4, 2022

The DynamoDB documentation explicitly says that the set types display set semantics, not list semantics, and this is the behavior I observe when using the service:

Each value within a set must be unique. The order of the values within a set is not preserved.

@github-actions github-actions bot removed the response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 10 days. label Oct 4, 2022
@yasminetalby yasminetalby added the needs-review This issue or PR needs review from the team. label Oct 10, 2022
@yasminetalby yasminetalby removed the needs-review This issue or PR needs review from the team. label Oct 17, 2022
@yasminetalby yasminetalby removed the service-api This issue is due to a problem in a service API, not the SDK implementation. label Oct 24, 2022
@yasminetalby
Copy link

Hello @chrylis ,

Update: The team has discussed the feature-request and has added it to the backlog.
There will be an update posted on this issue once the feature-request is implemented.

Thank you very much for your submission and collaboration.

Sincerely,

Yasmine.

@L-Applin L-Applin linked a pull request Oct 25, 2022 that will close this issue
12 tasks
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

aws-sdk-java-automation added a commit that referenced this issue Nov 18, 2024
…e545fc97b

Pull request: release <- staging/063a8293-a407-4e91-ae93-42ce545fc97b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request A feature should be added or improved.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants