Add client configuration overriding of SCHEDULED_EXECUTOR_SERVICE option

[scrocquesel]

Motivation and Context

Customer should be able to use their own ThreadPool and reuse it accros multiple clients.

#1690

Modifications

Introduce new client config methods to allow to override SCHEDULED_EXECUTOR_SERVICE option. It is optional and when not provided will default to the actual code that create a new ThreadPool for each clients

Testing

Unit tests ensure the override is applied on the client configuration.
I also tested in a private project by setting api call timeout to actually create new thread on the custom thread pool.

Screenshots (if appropriate)

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)

Checklist

• I have read the CONTRIBUTING document
• Local run of mvn install succeeds
• My code follows the code style of this project
• My change requires a change to the Javadoc documentation
• I have updated the Javadoc documentation accordingly
• I have added tests to cover my changes
• All new and existing tests passed
• I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
• My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

• I confirm that this pull request can be released under the Apache 2 license

[davidh44]

Thanks for the PR!! Looks great, we just need to make sure the custom ScheduledExecutorService doesn't get closed when the client is closed. Also a few minor comments.

[scrocquesel]

Thanks for the PR!! Looks great, we just need to make sure the custom ScheduledExecutorService doesn't get closed when the client is closed. Also a few minor comments.

Should I add more commits to the PR or force pushed ?

[davidh44]

Should I add more commits to the PR or force pushed ?

You can add more commits to the PR

[sonarqubecloud]

SonarCloud Quality Gate failed.   

1 Bug
0 Vulnerabilities
0 Security Hotspots
14 Code Smells

88.1% Coverage
1.2% Duplication

[davidh44]

@all-contributors please add @scrocquesel for code.

[davidh44]

@scrocquesel Great stuff! PR has been merged 👍

[debora-ito]

Trying again :) And adding contributors from previous PRs.

@all-contributors

please add @scrocquesel for code.
please add @dave-fn for code.
please add @L-Applin for code.

[allcontributors]

@debora-ito

I've put up a pull request to add @scrocquesel! 🎉

I've put up a pull request to add @dave-fn! 🎉

I've put up a pull request to add @L-Applin! 🎉